[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #19036 [Core Tor/Tor]: Write v3-status-votes file even when we fail to make a consensus

#19036: Write v3-status-votes file even when we fail to make a consensus
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  arma
     Type:  enhancement                          |         Status:
 Priority:  Medium                               |  merge_ready
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.???
 Keywords:  029-proposed, 029-nickm-says-yes,    |        Version:
  review-group-2, TorCoreTeam201605              |     Resolution:
Parent ID:                                       |  Actual Points:
 Reviewer:  sysrqb dgoulet                       |         Points:  0.1
                                                 |  remaining
                                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 arma's patch looks good to me.

 Since the patch literally moves a block of code around, I couldn't resist
 the urge to make it into a function. I pushed a commit that does this in
 my branch `feature19036`. If you feel that the refactor is not trivial,
 feel free to merge arma's patch and we can functionify later.

 Code:
 https://gitweb.torproject.org/user/asn/tor.git/commit/?h=feature19036&id=d875101e03680a372fe1ac91dfff0a9bde883dd3

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19036#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs