Re: [tor-bugs] #19035 [Core Tor/Tor]: Rip out client directory fetch instrumentation

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#19035: Rip out client directory fetch instrumentation
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  arma
     Type:  enhancement                          |         Status:
 Priority:  Medium                               |  needs_revision
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.9.x-final
 Keywords:  029-nickm-says-yes, review-group-2,  |        Version:
  TorCoreTeam201605                              |     Resolution:
Parent ID:                                       |  Actual Points:
 Reviewer:  dgoulet                              |         Points:  0.1
                                                 |  remaining
                                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 This is failing to build:

 {{{
 src/or/directory.c: In function âhandle_get_frontpageâ:
 src/or/directory.c:2875:72: error: unused parameter âargsâ [-Werror
 =unused-parameter]
  handle_get_frontpage(dir_connection_t *conn, const get_handler_args_t
 *args)
 }}}

 Adding `(void) args;` at the beginning of the function seems to work well
 for me.

 Some reference still exists that we could probably get rid off:

 {{{
 ./orconfig.h +536 /* #undef INSTRUMENT_DOWNLOADS */
 ./src/or/or.h +20 #ifndef INSTRUMENT_DOWNLOADS
 ./src/or/or.h +21 #define INSTRUMENT_DOWNLOADS 1
 }}}

 The rest lgtm;

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19035#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs