[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #19196 [Core Tor/Tor]: [prop250] Shared random version parsing fails on 32 bit

#19196: [prop250] Shared random version parsing fails on 32 bit
--------------------------------+------------------------
 Reporter:  teor                |          Owner:
     Type:  defect              |         Status:  closed
 Priority:  Medium              |      Milestone:
Component:  Core Tor/Tor        |        Version:
 Severity:  Normal              |     Resolution:  fixed
 Keywords:  tor-hs, regression  |  Actual Points:
Parent ID:  #16943              |         Points:
 Reviewer:                      |        Sponsor:
--------------------------------+------------------------
Changes (by dgoulet):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Oh my... this is a mistake I made in the commit that changed `reveal_num`
 and `version` to a different size.

 `prop250: Change reveal_num to uint64_t and version to uint32_t`

 So that wasn't dropped from the last #16943 review but rather introduced
 by me by mistake. Apologize.

 I've fixed it in the main branch under review. As for how to prevent that,
 running the tests on 32bit and #19063 as you said sounds like what we need
 to do.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19196#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs