[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22046 [Metrics/Atlas]: Remove cruft



#22046: Remove cruft
---------------------------+-----------------------------------
 Reporter:  cypherpunks    |          Owner:  irl
     Type:  defect         |         Status:  needs_information
 Priority:  Medium         |      Milestone:
Component:  Metrics/Atlas  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+-----------------------------------

Comment (by cypherpunks):

 Replying to [comment:2 irl]:
 > I don't seem to be able to get this one to apply.

 I've tested the patch and indeed it doesn't apply with `git am`. It seems
 to be an issue with the line endings. Using `git am --keep-cr` makes the
 patch apply properly.

 > I can see what's happening with the deletions, what's up with the
 renames? I can apply the diff manually if you can give some context on the
 renames.

 The renames are meant to keep the files that are part of Bootstrap intact.
 IMO the directory structure could be improved further by keeping all
 Bootstrap files in one directory instead of splitting them across multiple
 but that's out of the scope of this ticket.

 > Thanks for your work on this, it's been bugging me for a while. (:
 Me too, grepping for things would regularly turn up unrelated and
 duplicated files which got annoying.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22046#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs