[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #19607 [Metrics/metrics-lib]: avoid repeated keyword strings
#19607: avoid repeated keyword strings
---------------------------------+-----------------------------------
Reporter: iwakeh | Owner: karsten
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: metrics-lib 1.7.0
Component: Metrics/metrics-lib | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
---------------------------------+-----------------------------------
Comment (by karsten):
Looks good!
Just one question/suggestion: what do you think about moving
`serverAtMostOnce` and other parts that are only relevant for parsing
server descriptors to `ServerDescriptorImpl`?
Other than that, I'm not entirely sure what you mean by "additional lines
will go away" in your comment above. Which lines do you mean?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19607#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs