Re: [tor-bugs] #21846 [Core Tor/Torflow]: BwAuthority can't be run out of the box without manual work

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#21846: BwAuthority can't be run out of the box without manual work
-------------------------------+--------------------------------
 Reporter:  davidwf            |          Owner:  aagbsn
     Type:  enhancement        |         Status:  needs_revision
 Priority:  Medium             |      Milestone:
Component:  Core Tor/Torflow   |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:  chelseakomlo, tom  |        Sponsor:
-------------------------------+--------------------------------

Comment (by davidwf):

 Please see changes at 'git@xxxxxxxxxx:davidfaulkner12/bwauth.git', branch
 'nicedev'.

 > Why did you downgrade from SQLAlchemy 0.7.10 to 0.7.8?
 > Whichever way you choose to go, please find all instances of
 SQLAlchemy-0.7.* and make them consistent.

 Updated -- the PYTHONPATH variables in the shell scripts had no impact
 (and didn't resolve to anything on my machine at least), so I removed
 them. I used 0.7.8 because that's the last documented "compatible" version
 with Elixer.

 > For future patches, it is ok to provide a branch and use multiple
 commits - in fact, we prefer it!

 Noted! It was actually always in Github, I just through patches were
 preferred. :-)


 > readlink -f works with gnu readlink, but not with BSD readlink. It is
 possible to install BSD readlink on Linux, and GNU readlink on BSD or
 macOS. So we can't depend on uname, we should just try basename if
 readlink doesn't work here:

 I checked to see if the command fails, and only set the variable if
 necessary. This should work!


 > Some OSs only have a non-versioned python (e.g. macOS), so we should
 fall back to "which python" here:

 Done.

 > In stop_scan.sh: ...

 stop_scan.sh is actually just copy and pasted from the first lines of the
 run_scan.sh. I don't disagree with anything you said, but I'm not
 confident that I can make those changes in a way that works reliably
 without digging too deeply past the initial scope of "get this working on
 a laptop".

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21846#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs