[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22149 [Core Tor/Tor]: prop140: Update dir-spec with prop140 protocols

#22149: prop140: Update dir-spec with prop140 protocols
-------------------------------+------------------------------------
 Reporter:  nickm              |          Owner:  nickm
     Type:  defect             |         Status:  merge_ready
 Priority:  Medium             |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor       |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  TorCoreTeam201705  |  Actual Points:  .3
Parent ID:  #13339             |         Points:  .3
 Reviewer:                     |        Sponsor:  Sponsor4
-------------------------------+------------------------------------
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Generally looks good. Two questions:

 1) This patch marks prop140 as closed, but do we support the `/tor/status-
 vote/current/consensus/diff/<HASH>/<FPRLIST>.z` paths already?

 2) This is in the nitpick category. Do we want to change the delimiter in
 `X-Or-Diff-From-Consensus` to use "," and optionally " " like in the rest
 of HTTP?

 Catalyst also commented on a possible typo above.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22149#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs