[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #7869 [Core Tor/Tor]: ntor-onion-key is padded with an equal sign

#7869: ntor-onion-key is padded with an equal sign
-------------------------------------------------+-------------------------
 Reporter:  rransom                              |          Owner:
                                                 |  Jigsaw52
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Low                                  |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-relay, easy, intro,              |  Actual Points:
  tor-03-unspecified-201612                      |
Parent ID:                                       |         Points:
 Reviewer:  catalyst                             |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by catalyst):

 * status:  needs_review => needs_revision
 * reviewer:   => catalyst
 * cc: catalyst (added)
 * milestone:  Tor: unspecified => Tor: 0.3.2.x-final


Comment:

 [responding to a ping on IRC]

 Thanks for the patch!  0.3.1.x is in feature freeze so I'm putting this in
 0.3.2.x for now.  (Though it might make it into 0.3.1.x if there is time?
 It doesn't seem urgent to get into 0.3.1.x but feel free to explain if you
 disagree.)  #21872 means we have nicer macros for statically computing
 buffer lengths for various encodings, so I think it would be good to use
 them for this patch.  Also I think `base64_encode()` appends a NUL
 terminator so we can probably delete the code that separately adds one.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7869#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs