Re: [tor-bugs] #6837 [Core Tor/Tor]: More fine-grained modular decomposition

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#6837: More fine-grained modular decomposition
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:
     Type:  enhancement                          |         Status:  new
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.7
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-relay, tor-modularity            |  Actual Points:
  refactoring code-movement technical-debt       |
Parent ID:                                       |         Points:  parent
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorS-can
-------------------------------------------------+-------------------------
Changes (by nickm):

 * keywords:  tor-relay, tor-modularity => tor-relay, tor-modularity
     refactoring code-movement technical-debt


Old description:

> We should chop up our huger C files into smaller ones, based on actual
> module boundaries.
>
> This will make it harder for us to merge pending branches that touch that
> code, but those are at a low ebb right now, so it's a good time.
>
> The top 10 offenders in our current codebase are:
> {{{
>     3890 src/or/dirserv.c
>     3968 src/or/directory.c
>     4286 src/or/connection.c
>     4452 src/or/or.h
>     4735 src/or/control.c
>     4899 src/common/util.c
>     5263 src/or/routerparse.c
>     5468 src/or/config.c
>     5836 src/or/circuitbuild.c
>     5945 src/or/routerlist.c
> }}}

New description:

 We should chop up our huger C files into smaller ones, based on actual
 module boundaries.

 This will make it harder for us to merge pending branches that touch that
 code, but those are at a low ebb right now, so it's a good time.

 The top 10 offenders in our current codebase are:
 {{{
    4614 src/or/rendservice.c
    4839 src/or/channel.c
    5200 src/or/connection.c
    5386 src/or/or.h
    5648 src/common/util.c
    5666 src/or/directory.c
    5688 src/or/routerparse.c
    5771 src/or/routerlist.c
    7223 src/or/control.c
    8006 src/or/config.c
 }}}
 (updated May 2017)

--

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6837#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs