[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #7869 [Core Tor/Tor]: ntor-onion-key is padded with an equal sign
#7869: ntor-onion-key is padded with an equal sign
------------------------------+------------------------------------
Reporter: rransom | Owner: Jigsaw52
Type: defect | Status: needs_review
Priority: Low | Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-relay, intro | Actual Points:
Parent ID: | Points:
Reviewer: catalyst | Sponsor:
------------------------------+------------------------------------
Changes (by catalyst):
* keywords: tor-relay, easy, intro => tor-relay, intro
Comment:
Thanks for the updated patches! We were talking about this ticket on IRC
and concluded that it still needs additional work, which I'll try to
summarize. (nickm, please correct me if I got any of this wrong!) This
work includes making a new consensus method, which means updating `dir-
spec.txt` and the consensus method logic in `dirvote.c`. The sole changes
in the new consensus method would relate to padding of base64-encoded
ed25519 public keys.
Different directory authorities might create diverging consensus votes if
they make different choices about including `=` padding in `ntor-onion-
key`. This could be considered an existing ambiguity in `dir-spec.txt.`.
The new consensus method would require the absence of padding in `ntor-
onion-key`, while older ones would require its presence. Any changes to
`test_microdesc.c` should not change any of the reference `ntor-onion-key`
lines for the older microdesc formats.
I'm sorry if this is turning out to be more work than you expected. I'm
removing the "easy" keyword but keeping "intro" because it's clearly no
longer an "easy" task but it does touch a lot of different stuff in a not-
too-complicated way and therefore is a good way to get to know the Tor
code base better. Please feel free to continue revising your patch, or
alternatively some of us could work on it after 0.3.1 is closer to
release.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7869#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs