[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25951 [Core Tor/Tor]: Run flush_pending_log_callbacks() on an as-needed basis, not once-per-second

#25951: Run flush_pending_log_callbacks() on an as-needed basis, not once-per-
second
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  034-roadmap-subtask,                 |  Actual Points:
  034-triage-20180328, 034-included-20180328     |
Parent ID:  #25375                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 https://github.com/torproject/tor/pull/69 is the PR

 Note that this turned out to be easier than I'd thought, because we have a
 preexisting defect in that we already suppress a controller's log message
 events when those callbacks occur outside the main thread.  We should fix
 that some time, but perhaps not now.  See #25987 for ideas to fix that.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25951#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs