[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25927 [Core Tor/Tor]: Remove the need for gettimeofday_cached(); use monotonic time in ewma code

#25927: Remove the need for gettimeofday_cached(); use monotonic time in ewma code
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  034-roadmap-subtask,                 |  Actual Points:
  034-triage-20180328, 034-included-20180328     |
Parent ID:  #25375                               |         Points:
 Reviewer:  dgoulet                              |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 Looks good to me. Only one comment about the added random value of the
 tick number which is the only difference I could see on the EWMA side for
 which I believe it is a good addition!

 However, I can't test the compat functions for the `diff_msec()` so I
 would rely on travis and Jenkins to pick up any issues on other platforms
 if we do test them in the CI.

 Test passes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25927#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs