[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25817 [Applications/Tor Browser]: Add ansible scripts for setup of nigthly build server



#25817: Add ansible scripts for setup of nigthly build server
-----------------------------------------------+---------------------------
 Reporter:  boklm                              |          Owner:  tbb-team
     Type:  task                               |         Status:
                                               |  needs_revision
 Priority:  Medium                             |      Milestone:
Component:  Applications/Tor Browser           |        Version:
 Severity:  Normal                             |     Resolution:
 Keywords:  boklm201805, TorBrowserTeam201805  |  Actual Points:
Parent ID:                                     |         Points:
 Reviewer:                                     |        Sponsor:
-----------------------------------------------+---------------------------
Changes (by gk):

 * keywords:  boklm201804, TorBrowserTeam201804R => boklm201805,
     TorBrowserTeam201805
 * status:  needs_review => needs_revision


Comment:

 Okay, looks mostly good. Some typos and one question.

 s/setup/set up/ (when used as a verb)
 "for an example of how they it be used" <- not sure which version you
 wanted to have :)

 Now, I am a bit confused about the dependency to the test suite repo.
 Could you explain a bit more about how that is working. For instance, one
 thing I saw was that we already have a `tor-browser-
 nightly.rbm.local.conf` there but that one now gets overwritten with a
 newly added one we keep in the `tbb-nightly-build` dir in `tor-browser-
 build` but used afterwards which is a bit confusing.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25817#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs