[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #26004 [Core Tor/Tor]: Allow Tor to accept node_id at the end of a bandwidth file line
#26004: Allow Tor to accept node_id at the end of a bandwidth file line
-------------------------------------------------+-------------------------
Reporter: teor | Owner: (none)
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.3.5.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: fast-fix, 034-backport-maybe, 033 | Actual Points:
-backport-maybe, 032-backport-maybe, 031 |
-backport-maybe, 029-backport-maybe |
Parent ID: #25925 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):
* status: new => needs_revision
Comment:
That looks like it will work, and it seems like it passes the tests.
The checks are in a weird order, but we can fix that in a rewrite.
In our code style, we use character constants instead of integers. So 10
is '\n' and 0 is '\0'.
When we name branches, we call them after the tor branch they are based
on.
This branch is based on master, so it should not have "maint-0.2.9" in the
name.
Did you mean to base it on maint-0.2.9?
You can use "029" in branch names rather than "maint-0.2.9" if you want.
When you want a review on a ticket, you can put it in "needs_review".
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26004#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs