[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26004 [Core Tor/Tor]: Allow Tor to accept node_id at the end of a bandwidth file line

#26004: Allow Tor to accept node_id at the end of a bandwidth file line
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  fast-fix, 034-backport-maybe, 033    |  Actual Points:
  -backport-maybe, 032-backport-maybe, 031       |
  -backport-maybe, 029-backport-maybe, tor-      |
  dirauth                                        |
Parent ID:  #25925                               |         Points:
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by nickm):

 Two changes needed here:

   * If the input to this function is the empty string, `strlen(line) - 1`
 will underflow.
   * This branch needs a changes file.

 I've made both of these changes in my own branch (with the same name as
 yours) -- please let me know if you agree with them, and I'll merge.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26004#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs