[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25944 [Core Tor/Tor]: Investigate and fix tortls/context_new test failure on win32 CI builds

#25944: Investigate and fix tortls/context_new test failure on win32 CI builds
--------------------------------------------+------------------------------
 Reporter:  isis                            |          Owner:  (none)
     Type:  defect                          |         Status:  new
 Priority:  Medium                          |      Milestone:
Component:  Core Tor/Tor                    |        Version:  Tor:
                                            |  0.3.3.5-rc
 Severity:  Normal                          |     Resolution:
 Keywords:  tor-ci tor-windows tor-testing  |  Actual Points:
Parent ID:  #25549                          |         Points:  1
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------

Comment (by nickm):

 This code doing some of the same stuff as in #25943 -- creating X509
 objects via tor_malloc_zero.  If that's causing trouble there, it could
 also be the cause here.

 Honestly, both this test and the test at issue in #25943 seem very
 overfitted to me -- they're testing internal paths of the functions they
 test without much rhyme or reason, using objects that violate our
 invariants.  If we can't fix them, we should just replace them.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25944#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs