[tor-bugs] #26078 [Core Tor/Tor]: CID 1435546: Error handling issues (CHECKED_RETURN)

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#26078: CID 1435546:  Error handling issues  (CHECKED_RETURN)
------------------------------+---------------------------------
     Reporter:  asn           |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.4.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  coverity tor-client
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+---------------------------------
 Got a new coverity report today:

 {{{
 *** CID 1435546:  Error handling issues  (CHECKED_RETURN)
 /src/common/compat_libevent.c: 286 in periodic_timer_disable()
 280      * If the timer is already disabled, this function does nothing.
 281      */
 282     void
 283     periodic_timer_disable(periodic_timer_t *timer)
 284     {
 285       tor_assert(timer);
 >>>     CID 1435546:  Error handling issues  (CHECKED_RETURN)
 >>>     Calling "event_del" without checking return value (as is done
 elsewhere 4 out of 5 times).
 286       event_del(timer->ev);
 287     }
 288
 289     /** Stop and free a periodic timer */
 290     void
 291     periodic_timer_free_(periodic_timer_t *timer)
 }}}

 Seems to be related to #26063.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26078>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs