Re: [tor-bugs] #25903 [Core Tor/Tor]: Add OVERHEAD and DELIVERED fields to CIRC_BW events

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#25903: Add OVERHEAD and DELIVERED fields to CIRC_BW events
----------------------------------+------------------------------------
 Reporter:  mikeperry             |          Owner:  mikeperry
     Type:  defect                |         Status:  needs_information
 Priority:  Medium                |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor          |        Version:
 Severity:  Normal                |     Resolution:
 Keywords:  034-roadmap-proposed  |  Actual Points:
Parent ID:  #25546                |         Points:
 Reviewer:  isis                  |        Sponsor:
----------------------------------+------------------------------------
Changes (by mikeperry):

 * status:  needs_revision => needs_information


Comment:

 Hrmm. Right now there are no relay cell payloads larger than
 RELAY_PAYLOAD_SIZE, and checks against this max are earlier in all of the
 code that calls this function.

 Is this your only issue with the branch? IMO, in that case we should merge
 this, and then change this and the other checks on relay payload length to
 whatever mechanism we have for specifying the new max length depending on
 cell type once that invariant changes. Right now, we don't seem to have an
 alternative mechanism.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25903#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs