[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25947 [Core Tor/Tor]: Create unit test for dirserv_read_measured_bandwidths
#25947: Create unit test for dirserv_read_measured_bandwidths
--------------------------+------------------------------------
Reporter: juga | Owner: juga
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: bwauth, test | Actual Points:
Parent ID: #25925 | Points:
Reviewer: asn | Sponsor:
--------------------------+------------------------------------
Changes (by asn):
* status: needs_review => needs_revision
Comment:
Hello,
I pushed a branch `ticket25947_032_03_refactor` with a few changes:
a) Renamed `end_header` variable to `line_is_after_headers` to follow the
boolean variable convention of tor. Also clarified a few comments.
b) Fixed some trailing whitespace and double lines that were making `make
check-spaces` complain.
c) Slightly edited the changes file to follow usual convention.
Juga, if you like the changes, please squash them into your branch (so
that in the end you only have 4 commits) and let's turn this to
`merge_ready`.
Also, please test this branch against torflow and swbws to make sure sbws
to make sure that it functions properly. Let me know if you can't do this
and I will do it if needed.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25947#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs