[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25750 [Applications/Tor Launcher]: update Tor Launcher for ESR 60

#25750: update Tor Launcher for ESR 60
--------------------------------------------+------------------------------
 Reporter:  mcs                             |          Owner:  brade
     Type:  defect                          |         Status:
                                            |  needs_revision
 Priority:  Very High                       |      Milestone:
Component:  Applications/Tor Launcher       |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201805  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------
Changes (by mcs):

 * status:  needs_review => needs_revision
 * keywords:  ff60-esr, TorBrowserTeam201805R => ff60-esr,
     TorBrowserTeam201805


Comment:

 Replying to [comment:26 sysrqb]:
 > Great, thanks! I added a commit that synchronizes a few get..Pref()
 calls default values. I don't think we need all of them in sync, but it
 seems safer if retrieving a pref during initialization uses the same
 default value as defined in prefs.js.

 Thanks for doing that. The patch looks good except for three things:

 A. In `src/chrome/content/network-settings.js`, you do not want to add a
 second parameter to this line:
  `let prefBranch =
 TorLauncherUtil.getPrefBranch(kPrefBranchBridgeDBBridge);`
 but rather to this one:
  `let bridgeType = TorLauncherUtil.getCharPref(kPrefBridgeDBType);`

 B. In `src/components/tl-protocol.js`, I do not think we should change the
 code that retrieves `network.proxy.socks_port`. It was written to treat
 Firefox's default value of 0 as 9150.

 C. In `src/modules/tl-logger.jsm`, Kathy thinks we should leave the
 default default for `extensions.torlauncher.loglevel` as 0 so that if
 `defaults/preferences/prefs.js` cannot be read the user will get all
 logging (which may help with debugging whatever is wrong in their
 environment).

 > Thanks, that looks good. The only difference I see is this format
 inserts a comma between the date and time.
 >
 > {{{
 > 5/15/18, 23:20:43.525 [NOTICE] Bootstrapped 100%: Done
 > }}}

 Hmmm. On macOS at least, I see the comma with 8.0a7 as well:
 {{{
 5/16/18, 14:49:14.500 [NOTICE] Bootstrapped 100%: Done
 }}}

 Maybe things were different on other platforms though. Anyway, I think we
 are close enough now to the old format that we won't get many complaints
 (famous last words!)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25750#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs