[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25383 [Metrics/Website]: Deprecate stats.html and stats/*.csv files
#25383: Deprecate stats.html and stats/*.csv files
-----------------------------+------------------------------
Reporter: karsten | Owner: karsten
Type: enhancement | Status: needs_review
Priority: High | Milestone:
Component: Metrics/Website | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-----------------------------+------------------------------
Comment (by iwakeh):
Replying to [comment:16 karsten]:
> Alright, I now have some code to review. This code implements my latest
suggestion above. The R code is tested, the one-line Java code change is
not. Please take a look at [https://gitweb.torproject.org/karsten/metrics-
web.git/log/?h=task-25383 my task-25383] branch with two commits, 0975ca1
and d3b280a.
The second commit looks ok. Regarding the first commit: Interesting, I
wasn't aware of the `!!` operator in R. But, why can't we change the
(Java) calls of the R functions and have different names for parameters
and columns? This would be more readable.
>
> ...
> - Decide how we announce and make changes in the future, in particular
backward-incompatible ones. For example, Onionoo has a
`"next_major_version_scheduled"` field to announce backward-incompatible
changes, and we need something like that, too.
Good question! Should this be a part of the comment in the csv file?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25383#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs