[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26162 [Metrics/CollecTor]: Replace Gson with Jackson in CollecTor

#26162: Replace Gson with Jackson in CollecTor
-------------------------------+------------------------------
 Reporter:  karsten            |          Owner:  karsten
     Type:  enhancement        |         Status:  needs_review
 Priority:  High               |      Milestone:
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+------------------------------
Changes (by karsten):

 * status:  merge_ready => needs_review


Comment:

 I just pushed [https://gitweb.torproject.org/karsten/metrics-
 db.git/commit/?h=task-26162&id=01f63293314a9f0aca9aa4698bd8e7fe65519b43
 fixup commit 01f6329 to my task-21612 branch] that fixes an issue in the
 reference checker: while it's usually a good idea to skip fields with null
 or empty values, say, in Onionoo, the reference checker cannot handle that
 and needs to serialize and de-serialize empty strings. Before this fixup
 commit it would have de-serialized empty strings as `null` values, and
 that would have broken comparisons. Please review!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26162#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs