[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26073 [Applications/Tor Browser]: patch tor-browser-build.git for Firefox 60 ESR



#26073: patch tor-browser-build.git for Firefox 60 ESR
--------------------------------------------+------------------------------
 Reporter:  arthuredelstein                 |          Owner:  tbb-team
     Type:  defect                          |         Status:
                                            |  needs_revision
 Priority:  Very High                       |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  TorBrowserTeam201805, ff60-esr  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------
Changes (by gk):

 * status:  needs_review => needs_revision


Comment:

 Okay, `tor-browser-60.0.1esr-8.0-1` is a thing now. Looking at the commits
 in your `bug-26073` a general thing I noticed, please make sure the
 commits on `bug-26073` are still needed for the final branch. For instance
 there is no reason for us to merge
 71f7fd76779cb4b4a96ac17a80a82e5de64d0924 to `master`. It's been a WIP
 commit. Moreover, it's not been correct in the sense that it has been
 changing much more than just the nightly related branch. You only need to
 change the `git_hash` part in
 {{{
   nightly:
     git_hash: 'tor-browser-[% c("var/firefox_version") %]-[%
 c("var/torbrowser_branch") %]-1'
     tag_gpg_id: 0
     var:
       torbrowser_update_channel: default
 }}}
 + `firefox_platform_version`.

 e7b62d616f4a339257c69f2b895802c015b829eb does not need to get merged
 either. Just add a clean commit starting from `master` dealing with the
 lang packs. Etc.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26073#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs