[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26073 [Applications/Tor Browser]: patch tor-browser-build.git for Firefox 60 ESR

#26073: patch tor-browser-build.git for Firefox 60 ESR
--------------------------------------------+------------------------------
 Reporter:  arthuredelstein                 |          Owner:  tbb-team
     Type:  defect                          |         Status:
                                            |  needs_revision
 Priority:  Very High                       |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  TorBrowserTeam201805, ff60-esr  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------

Comment (by sukhbir):

 Replying to [comment:40 gk]:
 > Okay, we are close it seems. Here comes feedback to the latest branch
 (`bug-26073-rev1`):
 >
 > 61af9560529c3424e5a6494c6703ebde8591eea9 -- not okay
 >
 > There is no need to have two `+[% IF c("var/linux") %]` blocks right
 after each other, please merge them.
 >
 > I don't think you need to have "$rootdir/" in either case.
 >
 > 4dc04f54801b6a535a4935af10d42a939086dae5 -- not okay
 >
 > We should pick up boklm's idea.
 >
 > Please rebase your final branch against `master`.

 For review: https://github.com/azadi/tor-browser-
 build-1/tree/bug-26073-rev2

 This branch is based on `master` and also addresses the `mach` comment in
 #comment:42 in addition to boklm's changes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26073#comment:43>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs