[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26073 [Applications/Tor Browser]: patch tor-browser-build.git for Firefox 60 ESR



#26073: patch tor-browser-build.git for Firefox 60 ESR
--------------------------------------------+------------------------------
 Reporter:  arthuredelstein                 |          Owner:  tbb-team
     Type:  defect                          |         Status:
                                            |  needs_revision
 Priority:  Very High                       |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  TorBrowserTeam201805, ff60-esr  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------
Changes (by gk):

 * status:  needs_review => needs_revision


Comment:

 In Firefox for Windows we have
 {{{
   [% pc('gcc', 'var/setup', { compiler_tarfile =>
 c('input_files_by_name/gcc') }) %]
   # We need a link to our GCC, otherwise the system cc gets used which
 points to
   # /usr/bin/gcc.
   ln -s gcc /var/tmp/dist/gcc/bin/cc
 }}}
 It seems to me that minimalistic part should work for llvm as well, as all
 the boilerplate is done in gcc's setup part (with `hardened_gcc => 0` as
 you did).

 As I said, if you include `var/compiler` only for Linux, please make sure
 this happens in the llvm build script as well.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26073#comment:45>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs