Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#3723: Report version of bwscanners in votes
--------------------------+------------------------------------
 Reporter:  mikeperry     |          Owner:  (none)
     Type:  enhancement   |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-dirauth   |  Actual Points:
Parent ID:  #25925        |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by juga):

 * keywords:   => tor-dirauth


Comment:

 Since it is not being backported i based it on master, now in my branch
 `ticket3723`

 After looking more to `dirvote.c` i thought it was better to use
 `smartlist_t` instead of string, and get it converted to string in
 `format_networkstatus_vote`.

 Since `dirserv_read_measured_bandwidths` is call from
 `dirserv_generate_networkstatus_vote_obj`, i don't need a different
 function to obtain the headers.

 Since i didn't found specific tests for
 `dirserv_generate_networkstatus_vote_obj` and `format_networkstatus_vote`,
 i'm not sure how to add tests for the vote document.

 This code break other tests, hints?.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3723#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs