[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #26204 [Applications/Tor Browser]: Bundle d3dcompiler_47.dll for Tor Browser 8
#26204: Bundle d3dcompiler_47.dll for Tor Browser 8
--------------------------------------------+------------------------------
Reporter: gk | Owner: tbb-team
Type: defect | Status:
| needs_revision
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: ff60-esr, TorBrowserTeam201805 | Actual Points:
Parent ID: #26203 | Points:
Reviewer: | Sponsor:
--------------------------------------------+------------------------------
Changes (by boklm):
* status: needs_review => needs_revision
Comment:
The patch looks good to me, although I did not try to build the firefox
part.
However I think we are missing the part where we copy the
`d3dcompiler_47.dll` file to the bundle (I think in `$distdir/Browser`).
And a minor thing: you can indent the `make` lines in the `IF` to make
that easier to read. Or maybe it can be simplified like this:
{{{
diff --git a/projects/fxc2/build b/projects/fxc2/build
index 6ff3808..1b48326 100644
--- a/projects/fxc2/build
+++ b/projects/fxc2/build
@@ -8,11 +8,7 @@ mkdir -p /var/tmp/build
tar -C /var/tmp/build -xf [% project %]-[% c("version") %].tar.gz
cd /var/tmp/build/[% project %]-[% c("version") %]
-[% IF c("arch") == "i686" -%]
-make x86
-[% ELSE -%]
-make x64
-[% END -%]
+make [% IF c("var/windows-i686") %]x86[% ELSE %]x64[% END %]
mkdir -p /var/tmp/dist/fxc2/bin/
cp fxc2.exe /var/tmp/dist/fxc2/bin/
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26204#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs