Re: [tor-bugs] #30162 [Applications/Tor Browser]: Tor Browser bootstrap process got stuck after interrupting it

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#30162: Tor Browser bootstrap process got stuck after interrupting it
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-8.5-must,            |  Actual Points:
  TorBrowserTeam201904                           |
Parent ID:  #27609                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sisbell):

 Fixed in branch 0505

 !https://github.com/sisbell/tor-browser-
 build/commit/c1cf5b6d77637b5095b3063d4f5d5fedfab6e9e7

 Results:

 After fixes, I am unable to reproduce this bug.

 I can however, get it into a state where if I hit the 'connect' button
 prior to tor shutting down, it won't restart. The logs in the window
 correctly say that tor has shut down. If the user goes back in to the
 settings and back out and then hit connect, tor starts correctly. This is
 better than the original bug in the sense that the logs are correct and
 the user doesn't need to exist the app.

 To fix this, we can handle this at the UI level, perhaps with a way to
 disable the connect button during a shutdown phase. We do have a STOPPING
 event in the code but maybe something is not syncing between the service
 and the UI. The other option would be to try to handle a start queue in
 the service itself, which queues up start events during a shutdown.

 I also noticed that the logs say that two control ports are starting up.
 This still works since I added the behavior to handle reusing an existing
 tor process with a new control connection.  But I'm wondering if maybe
 somewhere we are calling start twice and that this has something to do
 with the original problem of multiple tor processes starting. I'll need to
 go through some more investigation but this isn't a blocker anymore due to
 code changes in topl which handle multiple starts.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30162#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs