[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #10760 [Applications/Tor Browser]: Integrate TorButton to TorBrowser core to prevent users from disabling it
#10760: Integrate TorButton to TorBrowser core to prevent users from disabling it
-------------------------------------------------+-------------------------
Reporter: Rezonansowy | Owner: tbb-
| team
Type: defect | Status:
| needs_information
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: AffectsTails, tbb-parity, | Actual Points:
TorBrowserTeam201904, GeorgKoppen201904 |
Parent ID: #24855 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by acat):
* status: new => needs_information
Comment:
Are there any issues of using in desktop the same
`toolkit/torproject/torbutton` used already in Android (#25013)?
Here https://github.com/acatarineu/tor-browser/commit/10760 I took the
patch from #28044 (https://gitweb.torproject.org/user/brade/tor-
browser.git/commit/?h=bug28044-01&id=79f8ea9c98c69eb594e7d2aace9199b3bceb22cb)
and did the same for torbutton, seems to work fine too. Note that `tor-
launcher` patch uses the path `browser/extensions/tor-launcher`, while
current Android and also this one uses `toolkit/torproject/torbutton`. I
realized that in this case the final code goes to `/chrome/torbutton`
inside `omni.ja` instead of `browser/omni.ja` as tor-launcher. Is one path
preferred to the other?
There is this `GetOverrideStringBundle` function in
https://gitweb.torproject.org/tor-
browser.git/tree/toolkit/xre/nsAppRunner.cpp?h=tor-
browser-60.6.1esr-8.5-1&id=178fcbbe24f543a15b165bdc680a5083247e87a3#n1823
that would need to be fixed, since the XPI would not be there. But I
wonder if this code is still needed since `general.useragent.locale` pref
is not there anymore (was moved to `intl.locale.requested`).
If this ticket is in the context of ESR68, then of course there is more
work to do. But if it's just `Integrate TorButton to TorBrowser core to
prevent users from disabling it` I think this patch might be good enough
(together with a change in `tor-browser-build`, will do if this approach
is fine). Perhaps we could track porting to ESR68, refactoring common
parts with tor-launcher, etc. in separate tickets. Or make this ticket
include all those, and keep working on this one.
Also, not sure if the idea is to abandon the `torbutton` git repository in
favour of continuing development in `tor-browser` repo. According to
https://gitweb.torproject.org/tor-browser-spec.git/tree/proposals/102
-integrate-tor-launcher-into-tor-browser.txt the plan for `tor-launcher`
is to keep the repo, would this also be fine for `torbutton`?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10760#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs