[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28044 [Applications/Tor Launcher]: Integrate Tor Launcher into tor-browser

#28044: Integrate Tor Launcher into tor-browser
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  brade
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Launcher            |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  AffectsTails, ux-team,               |  Actual Points:
  TorBrowserTeam201905R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by mcs):

 * status:  needs_revision => needs_review
 * keywords:  AffectsTails, ux-team, TorBrowserTeam201905 => AffectsTails,
     ux-team, TorBrowserTeam201905R


Comment:

 Replying to [comment:20 gk]:
 > b7e7058359b402e9f37e27a86b99b68702189cdb - looks good
 > 80cedf677bb43d10c6b37902ca22af7650752bf0 just one white space between
 "locale" and "torlauncher" (in `+% locale   torlauncher en-US %locale/en-
 US/`) as used for the other locales and no "/" at the end of `locale/en-
 US/` as done with the other locales, otherwise this looks good
 > 2dd09cb68db2b267cd12db7ce542406791fd6ef7 - there are some conflicts with
 the languages strings (sorry for that), otherwise this looks good

 We rebased the above changes and fixed the en-US locale issues that you
 found. We chose to add a trailing / for the non-en-US locales (by
 modifying import-translations.sh) since the results are more consistent
 with what Mozilla does. For example, see
 browser/extensions/pocket/locale/jar.mn. The three new tor-launcher
 patches are available on the bug28044-02 branch within the brade repo::
 https://gitweb.torproject.org/user/brade/tor-
 launcher.git/log/?h=bug28044-02


 > > There is one tor-browser commit:
 > > https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug28044-01&id=79f8ea9c98c69eb594e7d2aace9199b3bceb22cb
 >
 > Looks good to me.

 Rebased:
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug28044-02&id=70e8a9a20fea7bc4036fb1e8af01c65a82089f79

 > > And one tor-browser-build commit:
 > > https://gitweb.torproject.org/user/brade/tor-browser-
 build.git/commit/?h=bug28044-01&id=90a8ef3543cddebc2bfa946351c9eacc58641dd9
 >
 > Looks good to me.

 Rebased:
 https://gitweb.torproject.org/user/brade/tor-browser-
 build.git/commit/?h=bug28044-02&id=6d94f73dc055c1739a67ffd422f7f5bf29218723

 > > We also need to update the proposal to account for feedback we
 received from Tails as well as a couple of other things we learned; we
 will do that soon.
 >
 > Okay, works for me in a follow-up ticket.

 I filed #30473 for that task.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28044#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs