[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29982 [Applications/Tor Browser]: Clicking on cog/gear icon crashes Tor Browser for Android

#29982: Clicking on cog/gear icon crashes Tor Browser for Android
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  closed
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  tbb-mobile, TBA-a3, tbb-8.5-must,    |  Actual Points:
  TorBrowserTeam201905                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:8 sysrqb]:
 > Indeed. This was a simple and silly bug. When using an older Android
 versions on a tablet (or other large-screen device), Android tries
 creating a preference "flow", where it first shows a panel containing only
 headers (title and summary), then the user selects one of the headers and
 Android shows the real preference screen. We didn't implement the initial
 headers screen because it wasn't part of our goal (we really only targeted
 smaller devices, too).
 >
 > On newer versions of Android, the preferences are shown regardless of
 whether the headers are defined (so it handles our implementation well
 enough). On older versions of Android, I assume the user is shown all the
 defined headers - in our case, there are zero headers and therefore a
 blank screen is shown. This patch tells Android it should skip the headers
 and go straight to the fragment we define on the line above it.
 >
 > Branch `bug29982` in my repo.

 Nice find! The change looks good to me and I applied it tor `tor-
 browser-60.6.1esr-8.5-1` (commit 6a6052976627429027602a3b6871f0ae37aaa36d)
 and `tor-browser-60.6.1esr-9.0-1` (commit
 b914bb89ff0d07765c29a11ead947315f1e6d054).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29982#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs