[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30372 [Applications/Tor Browser]: Backport Letterboxing
#30372: Backport Letterboxing
-------------------------------------------------+-------------------------
Reporter: tom | Owner: tbb-
| team
Type: enhancement | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-fingerprinting-resolution, | Actual Points:
TorBrowserTeam201905R, GeorgKoppen201905 |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):
* status: needs_revision => needs_review
Comment:
Replying to [comment:9 acat]:
> I think there's something wrong with
https://d3kxowhw4s8amj.cloudfront.net/file/data/3mrddyqn42twqubxslh3/PHID-
FILE-j4tddtqktkpxt66evkb5/D29759.diff. The `defaultRounding` function was
deleted but I don't see that change in
https://phabricator.services.mozilla.com/D29759?download=true. Also,
`onst` instead of `const` :).
Ugh, the `onst` :(. I've fixed that in the new banch `bug_30372_v3`
(https://gitweb.torproject.org/user/gk/tor-
browser.git/log/?h=bug_30372_v3), following tom's advice to drop the last
two patches in favor of the one new one. Regarding `defaultRounding` it
got added in
https://hg.mozilla.org/try/rev/0b1eef9eeb06668fc06b3b4d877daaf957c3c1da
. However, the patch tom pointed to to keep us in sync is probably from a
later state where `defaultRounding` was already gone. I adapted the patch
for our esr60.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30372#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs