[tor-bugs] #30580 [Core Tor/Tor]: Tor rejects all POSTDESCRIPTOR controller requests

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#30580: Tor rejects all POSTDESCRIPTOR controller requests
--------------------------------+----------------------------------
     Reporter:  teor            |      Owner:  nickm
         Type:  defect          |     Status:  assigned
     Priority:  Medium          |  Milestone:  Tor: 0.4.1.x-final
    Component:  Core Tor/Tor    |    Version:  Tor: 0.4.1.1-alpha
     Severity:  Normal          |   Keywords:  041-must, regression
Actual Points:  0.2             |  Parent ID:
       Points:  0.5             |   Reviewer:
      Sponsor:  Sponsor31-must  |
--------------------------------+----------------------------------
 In #30091, we replaced this code:
 {{{
     if (!strcasecmpstart(option, "purpose=")) {
       option += strlen("purpose=");
       purpose = router_purpose_from_string(option);
       if (purpose == ROUTER_PURPOSE_UNKNOWN) {
         connection_printf_to_buf(conn, "552 Unknown purpose \"%s\"\r\n",
                                  option);
         goto done;
       }
     }
 }}}

 With this code:
 {{{
   line = config_line_find_case(args->kwargs, "purpose");
   if (line) {
     purpose = router_purpose_from_string(line->value);
     connection_printf_to_buf(conn, "552 Unknown purpose \"%s\"\r\n",
                              line->value);
     goto done;
   }
 }}}

 There's no purpose check any more (`if (purpose == ROUTER_PURPOSE_UNKNOWN)
 {`), so Tor rejects all POSTDESCRIPTOR requests.

 I'm assigning this bug to nickm and cc'ing catalyst, because they were the
 author and reviewer.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30580>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs