[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30561 [Core Tor/Tor]: Fixed tor_vasprintf on systems without vasprintf.
#30561: Fixed tor_vasprintf on systems without vasprintf.
-------------------------------------------------+-------------------------
Reporter: paldium | Owner: (none)
Type: defect | Status:
| merge_ready
Priority: Low | Milestone: Tor:
| 0.4.1.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.4.0.5
Severity: Minor | Resolution:
Keywords: 029-backport? 034-backport? | Actual Points:
035-backport? 040-backport? dgoulet-merge |
Parent ID: | Points:
Reviewer: nickm | Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):
* keywords: 029-backport? 034-backport? 035-backport? 040-backport? =>
029-backport? 034-backport? 035-backport? 040-backport? dgoulet-merge
* status: needs_review => merge_ready
Comment:
The patch looks okay to me. I've made some branches to fix the
formatting, add a changes file, backport to 0.2.9, and add a note about
removing this case from the code. I've confirmed that if I manually
disable the first two implementations of tor_vasprintf(), the code now
works and passes its test.
For 0.2.9 through 0.3.4: branch `ticket30561_029` with PR at
https://github.com/torproject/tor/pull/1052
For 0.3.5 and onward: branch `ticket30561_035` with PR at
https://github.com/torproject/tor/pull/1054
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30561#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs