[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

#33557: Update Android Toolchain for Fenix
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  gk
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-rbm,                 |  Actual Points:
  TorBrowserTeam202005, GeorgKoppen202005        |
Parent ID:  #33184                               |         Points:
 Reviewer:  sysrqb                               |        Sponsor:
                                                 |  Sponsor58-must
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen202005
     => tbb-mobile, tbb-rbm, TorBrowserTeam202005, GeorgKoppen202005
 * status:  needs_review => needs_revision


Comment:

 One annoying part I just realize is that we have `$CROSS_PREFIX-ranlib`,
 `$CROSS_PREFIX-ar`, `$CROSS_PREFIX-ld` etc. for `aarch64`, `x86`, and
 `x86_64` which is why we can easily use `var/configure_host` for them,
 even for the clang part which has an `$API` included additionally.

 Now, this does unfortunately not hold for `armv7`. There we have `arm-
 linux-androideabi` as `CROSS_PREFIX` but `armv7a-linux-androideabi$ARCH-
 clang` being used for the compiler.

 Here is what we can do:

 1) Work around that for the armv7 case (as done e.g. in the
 [https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=fenix_toolchain&id=c2c988bec9242fece4287dafdcf90f63cdb3b7f1
 patch for #33833]
 2) We could define yet another variable in `rbm.conf` making sure we have
 `arm-linux-androideabi` and `armv7a-linux-androideabi` available.
 3) We could just symlink the `CROSS_PREFIX` for `armv7` (currently `arm-
 linux-androideabi`) to `armv7-linux-androideabi`

 I think I'll do 3) and use `cross_prefix` instead of `configure_host` as
 the former seems to be clearer than the latter.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33557#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs