[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #33871 [Core Tor/sbws]: Scale exactly as torflow does?
#33871: Scale exactly as torflow does?
-------------------------------------------------+-------------------------
Reporter: juga | Owner: juga
Type: defect | Status:
| assigned
Priority: Medium | Milestone: sbws:
| 1.1.x-final
Component: Core Tor/sbws | Version:
Severity: Normal | Resolution:
Keywords: sbws-majority-blocker, sbws-roadmap | Actual Points:
Parent ID: #33775 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by mikeperry):
Replying to [comment:15 juga]:
> Replying to [comment:14 mikeperry]:
> > Oh I missed that sbws was including avg_bandwidth in the min().. That
definitely should not be there. Average will always be below observed,
>
> I don't think this is the case, just taking randomly a relay from my
`cached-descriptors`:
> {{{
> router rotateRelay21 188.227.170.106 2109 0 0
> fingerprint 1387 BB67 C0A1 BCE2 8133 FF72 39E0 27D5 4C56 538D
> bandwidth 2621440 10485760 5445375
> }}}
>
> I also looked 2 years ago at the spec and the code
(https://onbasca.readthedocs.io/en/latest/bandwidth_tor.html) and
concluded that the average is `min(RelayBandwidthRate, BandwidthRate,
MaxAdvertisedBandwidth)`, which are all set by the operator (or torrc
defaults), am i mistaken?.
> Maybe you're thinking on the `advertised` bandwidth, not the average?
Hrm it appears TorFlow is actually taking the minimum of all three here:
https://gitweb.torproject.org/pytorctl.git/tree/TorCtl.py#n459
So this should match sbws taking the min of all three..
Sorry I did not recall that either. It has been 8 years since I worked on
this code.
If it is not the order of composition of the min() you mention, then I am
not sure what the issue is still :/.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33871#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs