[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #34250 [Applications/Tor Browser]: Fix torbutton noscript-control race condition
#34250: Fix torbutton noscript-control race condition
--------------------------------------+------------------------------
Reporter: acat | Owner: acat
Type: defect | Status: needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam202005R | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------+------------------------------
Changes (by acat):
* keywords: TorBrowserTeam202005 => TorBrowserTeam202005R
* status: assigned => needs_review
Comment:
Patch for review in https://github.com/acatarineu/torbutton/commit/34250.
Unfortunately I could not find a simple way to reproduce the issue, other
than running a `tbb-testsuite` test. So, with `tor-browser-linux64-9.0
.10_en-US.tar.xz` build, and https://github.com/acatarineu/tor-browser-
bundle-testsuite/commit/8b36cbe63d4189a6b6d6dce3810239b734fb6e2e, I can
reproduce with:
`./tbb-testsuite --default-retry 1 --no-xdummy --enable-tests dom-objects-
enumeration-worker /tmp/tor-browser-linux64-9.0.10_en-US.tar.xz`
Without the torbutton patch, this fails with `NoSuchElementException:
Unable to locate element: enumeration`. With the patch, it fails with:
{{{
AssertionError: Unknown objects:
DOMError
toSource
uneval
}}}
The missing objects are expected, since the tests were fixed for a #33533
(33533+5) Firefox 77 build.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34250#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs