[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows
#34211: Add support for control signals (ex. Ctrl+C) in Windows
-------------------------------------------------+-------------------------
Reporter: TheDcoder | Owner: (none)
Type: enhancement | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.4.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
control,termination,signals,windows,winapi |
Parent ID: | Points:
Reviewer: ahf | Sponsor:
-------------------------------------------------+-------------------------
Comment (by TheDcoder):
I have revised my patch to fix several issues, these are the changes that
I made:
1. Add `static` specifier to the function definition in order to satisfy
gcc complaining about a missing prototype
1. Add a dummy statement which references the unused `ctrl_type`
parameter in order to satisfy gcc complaining about it being unused
1. Update the ticket file in !`changes` directory to use the more generic
`windows` category to group it along with other windows-specific changes
1. Add a new-line between the function type and function identifier as
per the general convention
Thanks to ahf and others who provided me with the feedback and input. I
have pushed the changes to my repository and the CI is still running, I
will attach the revised patch here too.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34211#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs