[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29368 [Metrics/Onionperf]: Add single onion service mode

#29368: Add single onion service mode
---------------------------------------+--------------------------------
 Reporter:  irl                        |          Owner:  phw
     Type:  enhancement                |         Status:  needs_review
 Priority:  Medium                     |      Milestone:
Component:  Metrics/Onionperf          |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID:  #33321                     |         Points:  2
 Reviewer:                             |        Sponsor:  Sponsor59-must
---------------------------------------+--------------------------------

Comment (by acute):

 This looks good! Appending here a git formatted patch to avoid passing the
 `single-onion` as a new parameter to all the server and config functions.
 Instead this initializes `self.single_onion` as a class attribute (e.g,
 the same way `serf.torserver_conf_file` works).
 In the future we could also treat `do_onion` and `do_inet` the same way,
 but the opportunity for simplification there is smaller.
 Let me know if this looks good to you!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29368#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs