Re: [tor-bugs] #1883 [Tor Relay]: Include GeoIP database identifier in extra-info descriptors

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#1883: Include GeoIP database identifier in extra-info descriptors
-------------------------+--------------------------------------------------
 Reporter:  karsten      |       Owner:                    
     Type:  enhancement  |      Status:  needs_review      
 Priority:  normal       |   Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay    |     Version:                    
 Keywords:               |      Parent:                    
-------------------------+--------------------------------------------------

Comment(by karsten):

 Replying to [comment:3 nickm]:
 > looks okay.  A couple of issues:
 >
 > In geoip_db_digest(), the documentation for the function should explain
 that calling hex_str() invalidates its return value.

 Added a sentence to the documentation.

 > In extrainfo_dump_to_string:
 >
 > +        s[pos] = '\0';
 > This should be unneeded, since tor_snprintf always nul-terminates.
 > +        write_stats_to_extrainfo = 0;
 > Why?  The right response on tor_snprintf() failing here is probably just
 to call the whole extrainfo a failure.

 Okay. I took this code out of the if block. If writing the geoip-db-digest
 line fails, writing the extra-info descriptor fails, too.

 > Other than that looks fine.

 Great! Thanks for the feedback. Please find the updated branch
 enhancement1883 in my public repository.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1883#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs