[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #2096 [EFF-HTTPS Everywhere]: Global Install Option
#2096: Global Install Option
-----------------------------------+----------------------------------------
Reporter: dm0 | Owner: pde
Type: defect | Status: reopened
Priority: normal | Milestone:
Component: EFF-HTTPS Everywhere | Version:
Resolution: | Keywords:
Parent: |
-----------------------------------+----------------------------------------
Comment(by dm0):
Sorry for the delay; I just noticed the patch was removed in git. I have
a problem with this: mainly that the entire AddonManager API is
asynchronous. I don't see how to work this into HTTPS Everywhere without
major rewrites. A new patch is attached that does not crash, but it
doesn't work in Firefox 4 as it does in Firefox 3.
To keep the changes simple, I tried to have it retrieve the path
asynchronously earlier in the plugin, and populate a variable with the
value to be used once getRuleDir is called. However, no matter where I
move that function call in the plugin, the value is only populated after
getRuleDir is run (at least on my machine). I don't really know anything
about writing Firefox addons (particularly for versions of Firefox that
are not released), so I might be missing something obvious, but it seems
that AddonManager calls are too slow to return the value in time.
I can try to make up a bigger patch later to properly use the asynchronous
calls, but maybe someone else can find an easier way to handle this before
then.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2096#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs