[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4403 [Thandy]: Thandy should fail when trying to create an existing dir inside a package

#4403: Thandy should fail when trying to create an existing dir inside a package
--------------------+-------------------------------------------------------
 Reporter:  chiiph  |          Owner:  nickm       
     Type:  defect  |         Status:  needs_review
 Priority:  normal  |      Milestone:              
Component:  Thandy  |        Version:              
 Keywords:          |         Parent:              
   Points:          |   Actualpoints:              
--------------------+-------------------------------------------------------

Comment(by nickm):

 A bare "except" is usually a bad idea.  If we want to ignore EEXIST, we
 should probably be catching only OSError, and re-raising if the "errno"
 field" isn't EEXIST.  (For instance, we probably *do* want to fail if the
 operation dies with EPERM, or because some bug made it so file["name"] was
 None, or something like that.)

 Also this code is still doing the join-with-/ thing, which means it will
 probably conflict with whatever fix we do for that.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4403#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs