Re: [tor-bugs] #4438 [Tor Directory Authority]: Dirauth sometimes exits when SafeLogging is toggled

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#4438: Dirauth sometimes exits when SafeLogging is toggled
-------------------------------------+--------------------------------------
 Reporter:  Sebastian                |          Owner:                    
     Type:  defect                   |         Status:  new               
 Priority:  normal                   |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Directory Authority  |        Version:                    
 Keywords:                           |         Parent:                    
   Points:                           |   Actualpoints:                    
-------------------------------------+--------------------------------------

Comment(by Sebastian):

 A second part might be

 {{{
 @@ -3404,8 +3406,9 @@ router_add_to_routerlist(routerinfo_t *router, const
 char

    /* If we have a router with the same identity key, choose the newer
 one. */
    if (old_router) {
 -    if (!in_consensus && (router->cache_info.published_on <=
 -                          old_router->cache_info.published_on)) {
 +    if (!in_consensus && !router_is_me(router) &&
 +        (router->cache_info.published_on <=
 +         old_router->cache_info.published_on)) {
        /* Same key, but old.  This one is not listed in the consensus. */
        log_debug(LD_DIR, "Not-new descriptor for router %s",
                  router_describe(router));
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4438#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs