Re: [tor-bugs] #4433 [Tor Client]: Return value bug in tor_addr_to_PTR_name

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#4433: Return value bug in tor_addr_to_PTR_name
------------------------+---------------------------------------------------
 Reporter:  4ZM         |          Owner:              
     Type:  defect      |         Status:  needs_review
 Priority:  minor       |      Milestone:              
Component:  Tor Client  |        Version:              
 Keywords:              |         Parent:              
   Points:              |   Actualpoints:              
------------------------+---------------------------------------------------

Comment(by nickm):

 Looks mostly good!

 I'd be a little more comfortable if the IPv6 address tested were not
 simply 8000::  -- that's enough of a special form that it makes me a
 little nervous about the correctness of other cases.  How about 8000::abcd
 ?

 On the documentation: "Return the number of chars printed" isn't correct;
 no characters are printed by this function.  Instead, something "return
 the number of characters written to <b>out</b>'" would be more accurate.

 Quick git note: this isn't mergeable as-is, since it includes a re-merge
 of master into the branch, and also includes the common_misc branch, and
 also includes your #4434 fix.  Generally, it's best to avoid unnecessary
 back-merges from a main branch into a topic branch , and to have each
 topic branch do only one thing so they can be merged independently.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4433#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs