[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #4312 [Tor Relay]: Rate limit renegotiations
#4312: Rate limit renegotiations
-----------------------+----------------------------------------------------
Reporter: asn | Owner:
Type: defect | Status: needs_review
Priority: normal | Milestone:
Component: Tor Relay | Version:
Keywords: | Parent:
Points: | Actualpoints:
-----------------------+----------------------------------------------------
Comment(by nickm):
Looks ok.
For the bufferevents case: The same callback-based approach works for
detecting excessive renegotiation, but we run into problems in knowing
what to do about it. We want to run some "kill this connection" callback
soon, but not immediately (because running that kind of thing from inside
the SSL callback from inside the bufferevent code is a recipe for Lots Of
The Wrong Kind Fun.) Probably, we could just use event_base_once code to
invoke a trampoline function to call the appropriate user-level callback
to call bufferevent_disable() and connection_mark_for_close() on the
connection. Does that make sense? I think it would work.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4312#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs