[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #4457 [Tor Client]: Assertion at startup on Windows 7 when socketpair fails
#4457: Assertion at startup on Windows 7 when socketpair fails
------------------------+---------------------------------------------------
Reporter: Vigdis | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: Tor: 0.2.2.x-final
Component: Tor Client | Version: Tor: 0.2.2.34
Keywords: | Parent:
Points: | Actualpoints:
------------------------+---------------------------------------------------
Changes (by nickm):
* status: new => needs_review
Comment:
Replying to [comment:2 nickm]:
> Hm. Several possibilities here, not all conflicting.
>
> * Set event_base_flag_nolock on newly constructed bases for situations
where we know we don't need to access a base from multiple threads. Right
now that's "every situation", but that won't be the case forever (maybe).
Done in 7363eae13cb8fe in my public repository, branch bug4457_022
Actually, this is only workable for 0.2.2; for 0.2.3 it will sometimes
fail, and we'll need to do this one instead:
> * Or maybe start with trying to create it regularly, and retry with
nolock if that fails.
Done as 7be50c26e8b2ec0bd in my public repository, branch bug4457_master.
> * Detect failures from event_base_new_with_config.
Done in 0f6c02161793fa1022fe7 in my public repository, branch bug4457_022
> * event_base_new_with_config() should log in this case.
Done in libevent in 4e797f388f736756b1531ce47ef210bd2119515f. Should be
in libevent 2.0.16-stable when it comes out (like, within 48 hours I
expect).
>
> * Libevent should decline to "enable threading" on a base in the case
when no threading callbacks have been registered with Libevent.
Done in libevent in e78741332985be96f2a44e71226b4adfe55aee7e. Should be
in libevent 2.0.16-stable when it comes out (like, within 48 hours I
expect).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4457#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs