[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4060 [EFF-HTTPS Everywhere]: Add a global enable / disable to the Toolbar Menu

#4060: Add a global enable / disable to the Toolbar Menu
----------------------------------+-----------------------------------------
 Reporter:  pde                   |          Owner:  pde         
     Type:  enhancement           |         Status:  needs_review
 Priority:  minor                 |      Milestone:              
Component:  EFF-HTTPS Everywhere  |        Version:              
 Keywords:                        |         Parent:              
   Points:                        |   Actualpoints:              
----------------------------------+-----------------------------------------

Comment(by jacobske87):

 Thanks for the link - it looks like I was missing the other callbacks.

 I updated the code here: https://github.com/kevinjacobs/HTTPS-
 Everywhere/commit/491c39903cb855bbb9f98a584ab6f548534c4cee and it now
 works for the previously problematic sites.

 I feel like this is a really hackish (bad) way to do this - Is there an
 easier way to toggle the other callbacks (I'm not even seeing
 addEventListener/addObservers for them?), or just use the if/else
 statements? I'm open to suggestions.

 Lastly - When I toggle enable/disable, I'm only having it reload the
 current tab. Are you okay with this? I feel like reloading all tabs is a
 little too aggressive (e.g. background Youtube tabs would start replaying,
 any unsubmitted form data could be lost, etc).

 Thanks for the feedback - I'm still learning the codebase.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4060#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs