[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4548 [Tor Bridge]: Implement dynamic (rakshasa) primes (part of proposal 179)

#4548: Implement dynamic (rakshasa) primes (part of proposal 179)
------------------------+---------------------------------------------------
 Reporter:  asn         |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Bridge  |        Version:                    
 Keywords:              |         Parent:  #3972             
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 Hm. On second thought, this kind of squashing doesn't make sense.  It
 seems like you're only suggesting grouping up changes into "here's a
 commit with a lot of changes".  What I had in mind was more like "Commit X
 does something , and then later commit Y changes how X did it in the first
 place: let's regard Y as a fixup for X."  Like, how f477ddcc20d5fc8c1 is
 purely a replacement for fa013e1bc520e11.

 This is probably too complicated for me to untangle well atm, so I'm going
 to merge this branch as-is (assuming it tests out ok for me).  Next time,
 please consider using git's "--squash" and --fixup" as you make commits
 that alter earlier commits.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4548#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs