[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #7013 [Tor]: Allow specifying the bind address of managed proxies
#7013: Allow specifying the bind address of managed proxies
----------------------------+-----------------------------------------------
Reporter: asn | Owner:
Type: task | Status: needs_review
Priority: normal | Milestone: Tor: unspecified
Component: Tor | Version:
Keywords: tor-bridge, pt | Parent:
Points: | Actualpoints:
----------------------------+-----------------------------------------------
Comment(by asn):
Replying to [comment:9 nickm]:
> Do you really want to be using "tor_addr_port_lookup" ? the 'lookup'
means that it can potentially do hostname resolution.
>
Good call. When writing that code, I noticed that all addrport parsing
code in config.c uses `tor_addr_port_lookup`, and I considered it an idiom
of some kind.
I added a fixup commit for this issue.
Should we also change the rest of the places in config.c where
`tor_addr_port_lookup` is used to use `tor_addr_port_split`?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7013#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs