[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #7304 [Tor]: tor_snprintf instead of snprintf
#7304: tor_snprintf instead of snprintf
-------------------------+--------------------------------------------------
Reporter: ultramage | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: Tor: 0.2.4.x-final
Component: Tor | Version:
Keywords: tor-client | Parent:
Points: | Actualpoints:
-------------------------+--------------------------------------------------
Changes (by nickm):
* keywords: => tor-client
* priority: trivial => minor
* milestone: => Tor: 0.2.4.x-final
Comment:
Sounds good to me. If this is a code-quality issue rather than actually
causing a bug, it should indeed be in 0.2.4.
If you (or anybody) can write a patch for this against master, I'd
appreciate that. A couple of things to keep in mind: The src/ext/* stuff
is externally-maintained code, so any changes made to it need to be
noninvasive. That would mean:
* doing "#define snprintf tor_snprintf" or something in a new
tinytest_local.h file and adding -DHAVE_TINYTEST_LOCAL to the build flags
for tinytest.c
* doing "#define snprintf tor_snprintf" in eventdns_tor.h, which is
where we keep noninvasive changes for that module.
* For OpenBSD_malloc_Linux.c, I have no idea. I'd be a little surprised
if that module built for Windows at all!
It would also be neat to have a way to make a list of forbidden functions
to make sure that no place in Tor (except for a couple of specific
wrappers) were calling them, so that nobody adds such calls back in the
future.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7304#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs